fix: Respect display.progress_bar=None in background threads#16715
fix: Respect display.progress_bar=None in background threads#16715
Conversation
shuoweil
requested review from
GarrettWu and
sycai
and removed request for
a team and
sycai
shuoweil
force-pushed
the
shuowei-anywidget-extraneous-output
branch
from
de201ee to
d887714
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to pass the progress_bar configuration through BigQuery events, allowing for more granular control over progress bar display. It updates several event classes to include a progress_bar field and modifies the callback logic to prioritize this field over global settings. Feedback suggests defining the 'fallback_to_global' sentinel as a constant to improve maintainability and refactoring the event mapping logic in create_bq_event_callback to reduce code duplication.
shuoweil
force-pushed
the
shuowei-anywidget-extraneous-output
branch
from
dce2e04 to
42e4a50
Compare
shuoweil
requested review from
TrevorBergeron,
chelsea-lin and
sycai
and removed request for
sycai
|
Per offline discussion, we would leave this setup to local thread. |
|
This PR doesn't touch the thread localility of the configuration object. Please continue with this fix. |
|
|
||
| import bigframes.session.executor | ||
|
|
||
| _FALLBACK_TO_GLOBAL = "fallback_to_global" |
There was a problem hiding this comment.
Generally "default" would communicate this more succinctly.
2 participants
Captures the progress bar option from the initiating thread and propagates it via events to background callbacks, ensuring options like None are respected.
Fixes #<461829560> 🦕